Fix Route with literal path segment makes route with variable path segment unavailable #3040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Implementation of #2960 will rewrite all of these code, but I think we should merge this to get new tests for this issue. |
|
I saw the PR, but did not find the time to take a good look |
|
@987Nabil No worries! Take your time |
jdegoes
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3036
So case happens when literal and other (codec) in subtree are both valid for path segment we try only literal one but tail is valid only for not-literal one
To fix this, I've added backtracking to other codec way in unhappy case when literal one was give us empty results. Also we don't do backtracking if others segments doesn't match literals.
This solution is optimized for cases without these conflicts, but when this case happened - backtracking is always slow, perhaps futher we need to investigate different approach to solve this issue.